BI- 2615 Incorrect sorting Exp Rep #, Exp Block #, Row and Col #457
Open
BI- 2615 Incorrect sorting Exp Rep #, Exp Block #, Row and Col #457
Conversation
| } else { | ||
| return second.localeCompare(first); | ||
| } | ||
| return this.sortAlphaAsNumeric(first, second, isAsc); |
Member
There was a problem hiding this comment.
I think this will change the sorting behavior for observations compared to what was here before. I'm not sure what the requirements are but I think some good test cases would be:
1, 2, 10
A1, A2, A10
1.2, 1.10, 1.3
-1, -2, -10
01, 1, 002, 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
BI- 2615 Incorrect sorting Exp Rep #, Exp Block #, Row and Col
Dependencies
BI_API :Develop
Testing
Expected Result
Checklist: